Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: BroadcastChannel initialization location #40049

Merged
merged 1 commit into from
Oct 2, 2023
Merged

fix: BroadcastChannel initialization location #40049

merged 1 commit into from
Oct 2, 2023

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Sep 29, 2023 •
edited

Description of Change

Refs #37421 (comment).
Closes #40060.
This patch was incorrectly removed in #37973 despite not making it into v18.

Checklist

Release Notes

Notes: none

@codebytere @patchup
fix: BroadcastChannel initialization location (#37421)
842ec8b 
* fix: BroadcastChannel initialization location

* chore: update patches

---------

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
@codebytere codebytere added semver/patch backwards-compatible bug fixes target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. labels Sep 29, 2023
@codebytere codebytere requested a review from a team as a code owner September 29, 2023 13:52
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 29, 2023
@codebytere codebytere removed target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. labels Sep 29, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 30, 2023
@codebytere codebytere merged commit 93bcb30 into main Oct 2, 2023
26 checks passed
@codebytere codebytere deleted the broadcast-channel branch October 2, 2023 08:57
@release-clerk
Copy link

release-clerk bot commented Oct 2, 2023

No Release Notes

This was referenced Oct 2, 2023
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Oct 2, 2023

I have automatically backported this PR to "26-x-y", please check out #40066

@trop trop bot added in-flight/26-x-y and removed target/26-x-y PR should also be added to the "26-x-y" branch. labels Oct 2, 2023
@trop
Copy link
Contributor

trop bot commented Oct 2, 2023

I have automatically backported this PR to "27-x-y", please check out #40067

@trop trop bot added in-flight/27-x-y merged/27-x-y PR was merged to the "27-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. and removed target/27-x-y PR should also be added to the "27-x-y" branch. in-flight/27-x-y in-flight/26-x-y labels Oct 2, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@codebytere @patchup
fix: BroadcastChannel initialization location (electron#40049)
3507284 
fix: `BroadcastChannel` initialization location (electron#37421)

* fix: BroadcastChannel initialization location

* chore: update patches

---------

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: BroadcastChannel support broken in version 26
2 participants
@codebytere @MarshallOfSound