Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When no theme color is found the event returns #000000 #10240

Closed
xywz opened this issue Aug 10, 2017 · 0 comments · Fixed by #10307
Closed

When no theme color is found the event returns #000000 #10240

xywz opened this issue Aug 10, 2017 · 0 comments · Fixed by #10307
Labels
bug 🪲 version/1.7.x

Comments

@xywz
Copy link

xywz commented Aug 10, 2017

  • Electron version: 1.7.5

Expected behavior

When a theme color is no longer present the webContents did-change-theme-color event should return null.

Actual behavior

The event returns "#000000".

How to reproduce

  1. Log the returned color of the webContents did-change-theme-color event.
  2. Go to https://electron.atom.io which has a theme color.
  3. Go to https://atom.io which does not have a theme color.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🪲 version/1.7.x
Projects
None yet
Milestone
No milestone
2 participants
@sofianguy @xywz