New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NativeWindow (Part 7): Expose TopLevelWindow in JavaScript #12637

Merged
merged 5 commits into from Apr 19, 2018

Conversation

Projects
None yet
1 participant
@zcbenz
Contributor

zcbenz commented Apr 17, 2018

const {TopLevelWindow} = require('electron')
const win = new TopLevelWindow({})

Currently there is no way to add child view to TopLevelWindow, it just has all non-WebContents related BrowserWindow APIs.

I will add docs once I have figured out a stable TopLevelWindow interface, now let's keep it undocumented.

@zcbenz zcbenz requested a review from electron/reviewers as a code owner Apr 17, 2018

@zcbenz zcbenz merged commit 6c9f306 into master Apr 19, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@zcbenz zcbenz deleted the expose-toplevel-window branch Apr 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment