Refactor NativeWindow (Part 7): Expose TopLevelWindow in JavaScript #12637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
force-pushed
the
expose-toplevel-window
branch
from
fe834d8
to
b4f5e38
Compare
zcbenz
force-pushed
the
expose-toplevel-window
branch
from
b4f5e38
to
7473b61
Compare
This was referenced Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no way to add child view to
TopLevelWindow, it just has all non-WebContents relatedBrowserWindowAPIs.I will add docs once I have figured out a stable
TopLevelWindowinterface, now let's keep it undocumented.