Refactor NativeWindow (Part 12): Do not use custom content view on macOS #12787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndersonZacharyT
approved these changes
May 2, 2018
nornagon
approved these changes
May 3, 2018
| cl, @selector(setFrameSize:), (IMP)SetFrameSize, "v@:{_NSSize=ff}"); | ||
| original_view_did_move_to_superview = | ||
| class_replaceMethod(cl, @selector(viewDidMoveToSuperview), | ||
| (IMP)ViewDidMoveToSuperview, "v@:"); |
There was a problem hiding this comment.
is this sort of messing about with the innards of Cocoa allowed in Mac App Store apps?
There was a problem hiding this comment.
There are a few uses of class_addMethod in Chromium, Apple seems to be cool about these uses.
I'll probably replace |
The views framework relies on NSWindow to return content size of window, since we don't use the borderless window, the original result would include titlebar. We have to override the function to return correct result for frameless window.
This was referenced Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove our custom content view on macOS, and rely on
views::Widgetto provide everything needed for layout.This PR would allow us to display arbitrary
views::Viewon macOS.