fix: tray setContextMenu crash #13513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Zhuo Lu <sethlu@mintkit.net> Co-authored-by: Kristine Zhang <kzhang@slack-corp.com>
nornagon
approved these changes
Jun 29, 2018
|
We have automatically backported this PR to "2-0-x", please check out #13516 |
|
We have automatically backported this PR to "3-0-x", please check out #13517 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12803 and related to #11818.
This PR addresses an issue whereby on close the Tray context menu attempted to run a
Callbackwhich had not been set and was thereforenull. Instead, we now wrap the call in anullcheck and post a task asynchronously to mirror parallel behavior on regular context menu close.cc @codebytere @sethlu @gnahzak
Checklist
npm testpasses