Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promisify contentTracing recording APIs #16642

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
3 participants
@codebytere
Copy link
Member

commented Jan 31, 2019

Description of Change

Backport of #16584.

Checklist

Release Notes

Notes: Converted contentTracing.startRecording() and contentTracing.stopRecording() to return a promise instead taking a callback.

@codebytere codebytere requested review from as code owners Jan 31, 2019

@ckerr

ckerr approved these changes Feb 1, 2019

Copy link
Member

left a comment

LGTM! 👍

@codebytere codebytere force-pushed the recording-bp branch from 1b8feaf to f94c3a8 Feb 1, 2019

@codebytere

This comment has been minimized.

Copy link
Member Author

commented Feb 1, 2019

This shouldn't be merged until it's rebased on #16643

feat: promisify contentTracing recording APIs (#16584)
* feat: promisify contentTracing.startRecording()

* feat: promisify contentTracing.stopRecording()

* test: convert specs for new promisified apis

* chore: deprecate and ensure legacy tests work

@codebytere codebytere force-pushed the recording-bp branch from f94c3a8 to db01fae Feb 1, 2019

@codebytere codebytere merged commit b31057c into 5-0-x Feb 1, 2019

12 of 16 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
appveyor: win-ia32-debug Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20190201.27 succeeded
Details
electron-arm64-testing Build #20190201.26 succeeded
Details
electron-mas-testing Build #20190201.27 succeeded
Details
electron-osx-testing Build #20190201.27 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 1, 2019

Release Notes Persisted

Converted contentTracing.startRecording() and contentTracing.stopRecording() to return a promise instead taking a callback.

@codebytere codebytere deleted the recording-bp branch Feb 1, 2019

@alejagapatrick
Copy link

left a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.