devtools: api to inspect service worker #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
with next update for chromium we get better observers for service wokers |
deepak1556
changed the title
|
/cc @paulcbetts , @hokein thoughts ? |
|
Into it! |
| @@ -317,6 +317,17 @@ void NativeWindow::InspectElement(int x, int y) { | |||
| agent->InspectElement(x, y); | |||
| } | |||
|
|
|||
| void NativeWindow::InspectServiceWorker() { | |||
There was a problem hiding this comment.
Why adding InspectServiceWorker for NativeWindow?
There was a problem hiding this comment.
to support BrowserWindow.inspectServiceWorker .
There was a problem hiding this comment.
Why is BrowserWindow.inspectServiceWorker needed? I think we can just use window.webContents.inspectServiceWorker.
There was a problem hiding this comment.
All the devtools api we have listed are on BrowserWindow besides if they use window.webcontents before its finished loading wouldnt webcontents.opendevtools crash ?
zcbenz
added a commit
that referenced
this pull request
May 27, 2015
devtools: api to inspect service worker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1331
Depends on electron-archive/brightray#107