Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: report module name when require fails in sandboxed renderers #17703

Merged
merged 1 commit into from
Apr 12, 2019
Merged

fix: report module name when require fails in sandboxed renderers #17703

merged 1 commit into from
Apr 12, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Apr 5, 2019 •
edited
Loading

Description of Change

Backport #17413

Added missing module name to the exception message thrown when require fails in sandboxed renderers. Follow up to chore: remove deprecated modules internally using remote.require in sandboxed renderer context

Checklist

Release Notes

Notes: Added missing module name to the exception message thrown when require fails in sandboxed renderers.

/cc @electron/wg-releases

@miniak miniak requested a review from a team April 5, 2019 09:46
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 5, 2019
@codebytere codebytere changed the title fix: report module name when require fails in sandboxed renderers (backport: 3-1-x) fix: report module name when require fails in sandboxed renderers Apr 5, 2019
@codebytere codebytere added 3-1-x backport This is a backport PR labels Apr 5, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 5, 2019
@miniak
Copy link
Contributor Author

miniak commented Apr 10, 2019

@codebytere all green, should be ready to merge :)

@jkleinsc jkleinsc merged commit 87a71ed into 3-1-x Apr 12, 2019
@release-clerk
Copy link

release-clerk bot commented Apr 12, 2019

Release Notes Persisted

Added missing module name to the exception message thrown when require fails in sandboxed renderers.

@jkleinsc jkleinsc deleted the miniak/sandbox-require-error-3-1-x branch April 12, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
3-1-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miniak @jkleinsc @codebytere