fix: devtools extensions not loading #20791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
force-pushed
the
miniak/fix-devtools-extensions
branch
from
15f3349
to
76da9fd
Compare
1 task
zcbenz
approved these changes
Oct 29, 2019
codebytere
approved these changes
Oct 29, 2019
|
Release Notes Persisted
|
|
I was unable to backport this PR to "7-0-x" cleanly; |
|
I have automatically backported this PR to "8-x-y", please check out #20842 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #20677
According to the docs for
chrome.runtime.connect(string extensionId, object connectInfo)both
extensionIdandconnectInfoarguments are optional, which means that justconnectInfocan be passed. We would assume it to beextensionId. It regressed in #16998Checklist
npm testpassesRelease Notes
Notes: Fixed devtools extensions not loading due to "Connect to unknown extension [object Object]" errors.