refactor: prefer using app.whenReady() #21972
Merged
+111
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the docs, specs, and lib, replace instances of `app.once('ready')`
(seen occasionally) and `app.on('ready')` (extremely common) with
`app.whenReady()`.
It's better to encourage users to use whenReady():
1. it handles the edge case of registering for 'ready' after it's fired
2. it avoids the minor wart of leaving an active listener alive for
an event that wll never fire again
ckerr
changed the title
zcbenz
approved these changes
Jan 31, 2020
codebytere
approved these changes
Feb 3, 2020
|
No Release Notes |
ckerr
added a commit
to electron/fiddle
that referenced
this pull request
Mar 25, 2020
This is a minor change, mostly for the `static/show-me/` demos to show best practices in Fiddle's sample code. More discussion is at electron/electron#21972
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
In the docs, specs, and lib, replace instances of
app.once('ready', ...)(seen occasionally) andapp.on('ready', ...)(very common) withapp.whenReady().then(...).The goal of this small change is to encourage new users to use whenReady():
Checklist
npm testpassesRelease Notes
Notes: no-notes