-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(extensions): devtools now open for background pages #22217
Conversation
87fb6ba
to
6b66e5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
5a80956
to
58dc875
Compare
6d2a859
to
da5464e
Compare
Is there any chance that it could be merged? |
287e659
to
a981f47
Compare
refactor(extensions): remove unused InitWithBrowserContext method fix(extensions): release background page WebContents to avoid crash The background page WebContents instance is managed by the ExtensionHost. fix(extensions): open background page devtools detached by default test(extensions): add background page devtools test chore: test fix for null web_contents() fix: close background page devtools in test after opening
a981f47
to
b021bc1
Compare
@zcbenz I fixed this up so it's no longer a WIP, the label can be removed now. |
No Release Notes |
I was unable to backport this PR to "10-x-y" cleanly; |
I was unable to backport this PR to "9-x-y" cleanly; |
I have automatically backported this PR to "11-x-y", please check out #25366 |
@samuelmaddock could you do backports for this? |
refactor(extensions): remove unused InitWithBrowserContext method fix(extensions): release background page WebContents to avoid crash The background page WebContents instance is managed by the ExtensionHost. fix(extensions): open background page devtools detached by default test(extensions): add background page devtools test chore: test fix for null web_contents() fix: close background page devtools in test after opening
refactor(extensions): remove unused InitWithBrowserContext method fix(extensions): release background page WebContents to avoid crash The background page WebContents instance is managed by the ExtensionHost. fix(extensions): open background page devtools detached by default test(extensions): add background page devtools test chore: test fix for null web_contents() fix: close background page devtools in test after opening
@samuelmaddock has manually backported this PR to "10-x-y", please check out #25566 |
@samuelmaddock has manually backported this PR to "9-x-y", please check out #25567 |
@codebytere done 👍 |
Description of Change
Ref #19447
This fixes DevTools not opening with Chrome extension background pages.
WebContents
type based onViewType
user data.WebContents
to enable opening devtools.Electron maintainers, please add
9-x-y
backport label.TODO:
ExtensionHost
crash on shutdown; likely related tomanaged_web_contents
deletingWebContents
instance.Checklist
npm test
passesRelease Notes
Notes: no-notes