Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setSimpleFullScreen shows traffic lights in frameless window #26126

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 23, 2020

Backport of #26096

See that PR for details.

Notes: Fixed an issue where frameless windows showed window controls after being in simple fullscreen mode on macOS.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 23, 2020
@trop trop bot requested a review from codebytere October 23, 2020 06:05
@trop trop bot added 10-x-y backport This is a backport PR labels Oct 23, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 23, 2020
@codebytere
Copy link
Member

tag did-change-theme-color event emits when theme color changes

known failure.

@codebytere codebytere merged commit e50545d into 10-x-y Oct 23, 2020
@release-clerk
Copy link

release-clerk bot commented Oct 23, 2020

Release Notes Persisted

Fixed an issue where frameless windows showed window controls after being in simple fullscreen mode on macOS.

@trop trop bot deleted the trop/10-x-y-bp-fix-setsimplefullscreen-shows-traffic-lights-in-frameless-window-1603433111420 branch October 23, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant