Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: target=_blank인 a 태그로 윈도우 오픈시 외부 브라우저로 열리도록 #55

Closed

Conversation

BitYoungjae
Copy link
Collaborator

@BitYoungjae BitYoungjae commented May 3, 2022

이슈 내용

  • 일렉트론 앱에서 shopify 주문서 상세정보와 같은 shopify 페이지를 새 창으로 띄웠을 때, 허용되지 않는 브라우저라는 메시지가 표시됨.

수정 내용

  • electron 버전 업 15.1.1 -> 18.2
  • breaking change 반영하여 nativeWindowOpen 옵션 제거
  • target=_blank 인 윈도우가 열릴 때 외부 브라우저로 열리도록 강제함.

Electron 15.1.1 -> 18.2 Breaking changes

16

  • The crashReporter API is now powered by Crashpad on Linux. #30278
  • Usage of the desktopCapturer.getSources API from the renderer process has been deprecated and will be removed. 30721

17

  • desktopCapturer.getSources is now only available in the main process. #30720

18

  • Removed the old BrowserWindowProxy-based implementation of window.open. This also removes the nativeWindowOpen option from webPreferences. #29405

@BitYoungjae
Copy link
Collaborator Author

/deploy

@BitYoungjae
Copy link
Collaborator Author

/deploy

@BitYoungjae
Copy link
Collaborator Author

/deploy

@BitYoungjae BitYoungjae marked this pull request as draft May 3, 2022 05:48
@BitYoungjae BitYoungjae closed this May 4, 2023
@BitYoungjae BitYoungjae deleted the bityoungjae/open-target-blank-in-external-browser branch October 31, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant