Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 72473550f6ff from angle #30961

Merged
merged 3 commits into from
Sep 21, 2021

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Sep 14, 2021

D3D11: Fix overflow in GenerateInitialTextureData.

Our use of unchecked math was causing OOB accesses with very large
textures. Unfortunately it's not easy to make a passing test that
reproduces this OOB access.

Bug: chromium:1241036
Change-Id: Icd2749f5b3116bb51390ce769fef22c49a11f307
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3136733
Reviewed-by: Geoff Lang geofflang@chromium.org
Commit-Queue: Jamie Madill jmadill@chromium.org
(cherry picked from commit 794b13ce9f874d472729ebd69897bc7ab9340a4b)
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3149277
Reviewed-by: Jamie Madill jmadill@chromium.org

Notes: Security: backported fix for CVE-2021-30626.

@ppontes ppontes requested a review from a team as a code owner September 14, 2021 13:44
@ppontes ppontes added 12-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Sep 14, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Sep 14, 2021
@ppontes ppontes force-pushed the cherry-pick/12-x-y/angle/72473550f6ff branch from 4d2908d to c854d17 Compare September 17, 2021 13:37
@zcbenz zcbenz merged commit 0f47c63 into 12-x-y Sep 21, 2021
@zcbenz zcbenz deleted the cherry-pick/12-x-y/angle/72473550f6ff branch September 21, 2021 05:41
@release-clerk
Copy link

release-clerk bot commented Sep 21, 2021

Release Notes Persisted

Security: backported fix for CVE-2021-30626.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants