-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include all standard paper sizes for webContents.print() #37159
Conversation
bfd2bdd
to
4ec9f2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we support all ISO paper sizes https://source.chromium.org/chromium/chromium/src/+/main:chrome/common/printing/print_media_l10n.cc;l=35-589;bpv=0 ?
@deepak1556 I defaulted to what's currently supported in the Chrome DevTools Protocol - we could expand the list but then imo we should do so for both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codebytere does A6
need to be declared in PDFPageSizes
?
Sounds good, thanks for clarifying. |
@jkleinsc oops, yes, missed that! addressed. |
4ec9f2e
to
c980078
Compare
c980078
to
16b65c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a source list for this somewhere in Chrome, or did we invent this? nvm, already answered
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
Release Notes Persisted
|
I have automatically backported this PR to "22-x-y", please check out #37263 |
I have automatically backported this PR to "23-x-y", please check out #37264 |
I have automatically backported this PR to "24-x-y", please check out #37265 |
@codebytere can add 8K and 16K in paper sizes?thinks |
Description of Change
Closes #37127. Adds missing standard page sizes.
Checklist
npm test
passesRelease Notes
Notes: Added several standard page size options to
webContents.print()
.