fix: guard more private API usage on MAS builds #37309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
|
We may also have to filter out |
|
@VerteDinde That just requires us to not guard the |
zcbenz
reviewed
Feb 17, 2023
There was a problem hiding this comment.
The unused function error need to be resolved.
../../sandbox/mac/seatbelt.cc:50:6: error: unused function 'HandleSandboxResult' [-Werror,-Wunused-function]
bool HandleSandboxResult(int rv, char* errorbuf, std::string* error) {
^
../../sandbox/mac/seatbelt.cc:63:6: error: unused function 'HandleSandboxErrno' [-Werror,-Wunused-function]
bool HandleSandboxErrno(int rv, const char* message, std::string* error) {
^
|
Release Notes Persisted
|
This was referenced Feb 21, 2023
|
I have automatically backported this PR to "23-x-y", please check out #37363 |
|
I have automatically backported this PR to "24-x-y", please check out #37364 |
trop
bot
added
in-flight/23-x-y
and removed
target/23-x-y
trop
bot
added
merged/24-x-y
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
mifi
added a commit
to mifi/lossless-cut
that referenced
this pull request
Apr 8, 2023
to fix mas issue electron/electron#37309
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #37292.
Refs CL:4079319
Guards more usage of private APIs (see here) on Mac App Store builds causing rejections.
Checklist
npm testpassesRelease Notes
Notes: Fixed potential private API usage for MAS builds on macOS.