fix: only exit fullscreen conditionally with setKiosk
#38368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
georgexu99
approved these changes
May 17, 2023
codebytere
force-pushed
the
fix-fullscreen-kiosk-23
branch
from
517fab7
to
b807f42
Compare
zcbenz
approved these changes
May 22, 2023
codebytere
force-pushed
the
fix-fullscreen-kiosk-23
branch
from
b807f42
to
70d6504
Compare
jkleinsc
force-pushed
the
fix-fullscreen-kiosk-23
branch
from
70d6504
to
6bc26dc
Compare
|
Is there a reason this was closed? Our team is on version 23. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #38219.
See that PR for details.
Notes: Fixed an issue where calls to
window.setKiosk(false)would exit fullscreen regardless of the fullscreen state prior to kiosk mode.