Chrome 54 update #7909
Closed
Chrome 54 update #7909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Boom failed! Please fix this before anything else. |
|
@groundwater You may be already aware of this, but your commit is changing the line-endings fron LF to CRLF. |
|
Hey @poiru thanks for the tip! I thought git for windows would fix that, but I'll see if I can adjust Atom editor to use the correct line endings. Hi @warengonzaga, I would like to keep this discussion reserved for people working on the chrome54 fix. I appreciate your enthusiasm, but this is a very early work, and there is much to be done. Thanks! |
This was referenced Nov 11, 2016
|
If y'all upload libchromiumcontent for Windows I can pitch in on that front |
zcbenz
force-pushed
the
chrome54
branch
3 times, most recently
from
b62b531
to
eb7f9cc
Compare
kevinsawicki
force-pushed
the
chrome54
branch
from
c1cac1c
to
1a63b1a
Compare
|
This is closed in favor of #8406. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug build compiles on:
Release build compiles on:
Tests passing on:
Fix features:
insertCSSinspectElementnavigator.requestMIDIAccessMerge:
Fixes #6571
Fixes #7814
Fixes #8062
Fixes #8366