Skip to content
This repository has been archived by the owner on Nov 29, 2022. It is now read-only.

replace Jekyll with a Node server 🐢🚀 #758

Closed
wants to merge 195 commits into from
Closed

replace Jekyll with a Node server 🐢🚀 #758

wants to merge 195 commits into from

Conversation

zeke
Copy link
Contributor

@zeke zeke commented Jul 7, 2017

🚧 DO NOT MERGE 🚧

This PR replaces Jekyll with a Node server using Express.

Changes to this branch are auto-deployed to electronjs.org.

Reasons™

  • Developer Experience. It should be fun and easy to work on the site, and Jekyll is not always up to that task. See How can we improve Jekyll performance and usability? #668
  • Consistency in Tooling. Nearly every project that the Electron team works on is written in JavaScript, and it is our language/ecosystem of expertise. Eliminating the Ruby dependency will make it easier for team members to work on the app, make more opportunities for code sharing across projects, and lower the barrier to entry for outside contributors from the community.
  • Server-y Things. Using a web server will allow us to do things that a static site can't, like setting proper redirects for deprecated URLs or conditionally displaying content based on a browser's Accept-Language header. See Phasing out redirects for old docs URLs #638
  • Internationalization. Eventually we'll be serving up content in different languages from electron-i18n. This will require a level of performance and flexibility that simply isn't possible with Jekyll.
  • Flexibility. As the site grows and improves, we want to have the option to support things like dynamic routes, forms that users can fill out, etc.

Highlights

🌍 Localized Content - automated flow in and out of Crowdin means docs in any language!

📖 Updated Documentation - always fresh from the master branch.

💻 Apps - now categorized and each app has its own URL.

🔧 Consistent Tooling - goodbye ruby; node is everywhere.

🛰 Dynamism. running a webserver gives us dynamic routes, forms that users can fill out, etc.

🤖 Automated Deployment - greenkeeper and semantic-release ftw

Progress

See the project board.

@zeke zeke temporarily deployed to electron-website November 11, 2017 17:59 Inactive
@zeke zeke temporarily deployed to electron-website November 12, 2017 05:16 Inactive
@zeke zeke temporarily deployed to electron-website November 12, 2017 23:32 Inactive
@zeke zeke temporarily deployed to electron-website November 12, 2017 23:39 Inactive
@zeke zeke temporarily deployed to electron-website November 13, 2017 19:23 Inactive
* i18n for /community

* Add tests

* Fix small error

* remove unused localized strings
@zeke
Copy link
Contributor Author

zeke commented Nov 13, 2017

I'm going to close this, as this PR is never actually going to land on the gh-pages branch. Also we've already made neo the (temporary) default branch, so any new PRs will use it as the target. I'll post a link to the blog post when the new site officially drops.

@zeke zeke closed this Nov 13, 2017
@zeke
Copy link
Contributor Author

zeke commented Nov 16, 2017

It's live: https://electronjs.org/blog/new-website

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants