feat: allow installing of multiple version simultaneously #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzhao
reviewed
Aug 8, 2022
aryanshridhar
force-pushed
the
Allow-MultipleDownloads
branch
from
7e22143
to
d4c3d6d
Compare
aryanshridhar
force-pushed
the
Allow-MultipleDownloads
branch
from
d4c3d6d
to
26b46f0
Compare
VerteDinde
approved these changes
Aug 9, 2022
erickzhao
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the support to allow installing of multiple electron version together.
Previously, there was a single global variable denoting the installing state of electron version. Hence, when a new version triggers the
installfunction - it throws an error due to this check.With changing it to be
Map, we can keep track to all version and their installing state :)