-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adjust gist link address bar #94
Conversation
Hey! Solid start, but there are a few issues here:
This really is a solid start though! |
Fixed via Electron Forge v6.0.0-beta.28 See: electron/forge#567
fix: don't hang on window close when run via npm start
Fixed via Electron Forge v6.0.0-beta.28 See: electron/forge#567
Thank you, @felixrieseberg! I've updated accordingly. Please review again. 🙏
Tested the original bug I introduced to understand more. Reverted to use the original placeholder attribute & its value.
Inspected other input field's style more, & updated the style for the gist URL field's style.
Read the regex in the gist.ts logic here, & used the |
feat: enable options for the text editor
…into BeniCheni-gist-link-input
Hey @BeniCheni, good stuff! I found a few more small issues and decided to just fix them on your branch. I'm now just waiting to see if I broke any tests - if I didn't, I'll merge this later today! |
Fixes: #85
Use a single
<input>
for the gist link address bar:Input
withtype=url
placeholder
to leverage onvalue
for gist link(P.S.: These changes are based on my best "guesses". Happy to update according to review & advice. 🙏🏻)
Test
Test w. token population