-
-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osxSign is not supported until Electron Packager 8.6.0 #162
Comments
As answered on Slack. /cc @malept Am I correct ^^ |
That's correct. In fact I found some weirdness this morning related to the API naming change, so it's probably a good thing that I didn't release yet. 😰 |
is this working now or is |
The change in Packager was released in 8.6.0, which was on March 14. |
Any update here? |
Use |
Okay great figured it out. For anyone else stumbling on this thread, this is what worked for me:
|
@onassar Thank you so much for clarifying this. I felt like I was taking crazy pills looking for this. I suppose that's what happens when you have a umbrella framework that is puppeteering all of these other libraries and you have to go spelunking through each library to find what configuration is required. Anyway, your config worked great. Mine ended up looking like this: "electronPackagerConfig": {
"osxSign": {
"identity": "Developer ID Application: Joshua Pinter (<my_id>)"
}
} |
Great to hear @joshuapinter Good luck :) |
For anyone who finds this looking for a package.json config example, the new key is
|
feat: support upcoming Electron 5.0 with nodeIntegration disabled by default
Please describe your issue:
i'm trying to sign my app on mac, as electron-packager documentation says setting
osxSign:true
should sign app after packaginghere is my config:
for example
name
andicon
properties work correctly but settingosxSign
does not do anythingbtw running signing command manually works correctly too:
can anyone suggest anything?
Console output when you run
electron-forge
with the environment variableDEBUG=electron-forge:*
. (Instructions on how to do so here). Please include the stack trace if one exists.What command line arguments are you passing?
What does your
config.forge
data inpackage.json
look like?Please provide either a failing minimal testcase (with a link to the code) or detailed steps to
reproduce your problem. Using
electron-forge init
is a good starting point, if that is not thesource of your problem.
The text was updated successfully, but these errors were encountered: