-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty config in @electron-forge/publisher-nucleus@6.0.0-beta.22 #541
Comments
Can you verify this is still an issue on |
Well, I'm forcing 25:
in
and it's still empty
Now firing npm run publish:
|
@dsheiko Can you post your forge configuration |
It's above in the very first post forge.config.js |
I can't reproduce this on {
"name": "test-nucleus",
"productName": "test-nucleus",
"version": "1.0.0",
"description": "My Electron application description",
"main": "src/index.js",
"scripts": {
"start": "electron-forge start",
"package": "electron-forge package",
"make": "electron-forge make",
"publish": "electron-forge publish",
"lint": "echo \"No linting configured\""
},
"keywords": [],
"author": "sattard",
"license": "MIT",
"config": {
"forge": {
"packagerConfig": {},
"makers": [
{
"name": "@electron-forge/maker-squirrel",
"config": {
"name": "test_nucleus"
}
},
{
"name": "@electron-forge/maker-zip",
"platforms": [
"darwin"
]
},
{
"name": "@electron-forge/maker-deb",
"config": {}
},
{
"name": "@electron-forge/maker-rpm",
"config": {}
}
],
"publishers": [
{
"name": "@electron-forge/publisher-nucleus",
"config": {
"host": "http://localhost:3030",
"appId": "2",
"channelId": "5542496b41ba12ab15a31862d78088f4",
"token": "TOKEN"
}
}
]
}
},
"dependencies": {
"electron-squirrel-startup": "^1.0.0"
},
"devDependencies": {
"@electron-forge/cli": "^6.0.0-beta.25",
"@electron-forge/maker-deb": "^6.0.0-beta.25",
"@electron-forge/maker-rpm": "^6.0.0-beta.25",
"@electron-forge/maker-squirrel": "^6.0.0-beta.25",
"@electron-forge/maker-zip": "^6.0.0-beta.25",
"@electron-forge/publisher-nucleus": "^6.0.0-beta.25",
"electron": "2.0.5"
}
} And it works as expected and loads that config. Can you post more information about your environment, in particular your node version |
I did it in the very first post Here my project https://file.io/FrXNWG
You are expected to have:
As I previously explained, that happens because config object is empty P.S. Maybe it happens because I explicitly force the target like
|
@dsheiko That'll be it
We probably aren't resolving the config correctly for those cases, for now just run |
@vintproykt per the docs, |
* build: update Electron releases JSON * build: update Electron releases JSON Co-authored-by: Electron Bot <electron-bot@users.noreply.github.com>
If you check config object assigned in https://github.com/electron-userland/electron-forge/blob/e55a9d5beb666a944ae730e6ed0a2ba6b5594c93/packages/publisher/nucleus/src/PublisherNucleus.ts#L35
it's empty (regardless of how config declared as manifest block or a separate file) and therefore the fetch function https://github.com/electron-userland/electron-forge/blob/e55a9d5beb666a944ae730e6ed0a2ba6b5594c93/packages/publisher/nucleus/src/PublisherNucleus.ts#L57 receives empty config.host and throws an error (Absolute URL required).
As a dirty workaround I had to do the following, given I have the only publisher:
So it publishes correctly to Nucleus server
My env: Windows 10, Node.js 10.4.1
package.json
forge.config.js
The text was updated successfully, but these errors were encountered: