feat(plugin-webpack): allow specifing a seperate webpack config for your preload #2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyruzic
commented
Jan 10, 2022
| const rendererWebpackConfig = await generator.getRendererConfig(config.renderer.entryPoints); | ||
| // Our preload config plugins is an empty list while our renderer config plugins has a member | ||
| expect(preloadWebpackConfig.name).to.equal('preload'); | ||
| expect(rendererWebpackConfig.name).to.equal('renderer'); |
There was a problem hiding this comment.
This test verifies that the preload webpack config is used if it is specified by setting the property name on the renderer config and preload config and verifying that the name is as expected on each.
MarshallOfSound
approved these changes
Feb 3, 2022
This was referenced Feb 3, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
Allows you to specify a seperate webpack config for the preload process. This is 100% necessary in order to use react refresh see:
#1936
pmmmwh/react-refresh-webpack-plugin#263
There is a pr open for this currently but the author appears to have abandoned it. This is blocking me so lets get this fixed. I am happy to write documentation for it if needed.