feat(maker-zip): add new macUpdateManifestBaseUrl and macUpdateReleaseNotes options #3107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eNotes options These two new options allow the zip maker to spit out a valid RELEASES.json file for use with the Electron autoUpdater. It makes the most sense to put this in the zip maker as the zip artifacts are what the macOS auto updater uses to update. This is part 1 of a multi-part series of PRs to forge + update-electron-app + forge-docs to make the story for "I use forge, I want to update my app from static storage like S3" incredibly easy to tell.
MarshallOfSound
force-pushed
the
zip-maker-squirrel
branch
from
224d5fa
to
c0d877c
Compare
erickzhao
reviewed
Dec 6, 2022
Co-authored-by: Erick Zhao <erick@hotmail.ca>
erickzhao
reviewed
Dec 13, 2022
|
DMGs aren't used for updates in any way, you need to build a zip. The only reason to make a DMG is to use as the download users get from your website the first time. |
erickzhao
approved these changes
Dec 13, 2022
|
Makes sense to me. Thanks! |
VerteDinde
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two new options allow the zip maker to spit out a valid RELEASES.json file for use with the Electron autoUpdater. It makes the most sense to put this in the zip maker as the zip artifacts are what the macOS auto updater uses to update. They are a parallel to the
remoteReleasesoption you can pass to the squirrel windows maker.This is part 1 of a multi-part series of PRs to forge + update-electron-app + forge-docs to make the story for "I use forge, I want to update my app from static storage like S3" incredibly easy to tell.