build: migrate from github actions to circleci #3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgexu99
changed the title
georgexu99
changed the title
georgexu99
force-pushed
the
circleci
branch
25 times, most recently
from
0816a75
to
0d5dc0f
Compare
georgexu99
force-pushed
the
circleci
branch
13 times, most recently
from
e1063a8
to
723a533
Compare
georgexu99
commented
May 16, 2023
| npm install -g npm@8 | ||
| echo 'C:\Program Files (x86)\WiX Toolset v3.11\bin' >> $GITHUB_PATH | ||
| npm config set node-gyp "$GITHUB_WORKSPACE\node_modules\node-gyp\bin\node-gyp.js" | ||
| - name: Linux specific setup |
There was a problem hiding this comment.
This was dead code, is this something we need?
| @@ -143,11 +143,11 @@ | |||
| "yaml-hook": "^1.0.0" | |||
| }, | |||
| "optionalDependencies": { | |||
| "@malept/electron-installer-flatpak": "^0.11.2", | |||
There was a problem hiding this comment.
these aren't needed for this PR- let me know if it would be more preferred to separate these upgrades to a separate PR
There was a problem hiding this comment.
I'm fine with upgrading these in this PR, as long as tests are passing 👍 We can do a little manual test of binaries next time we do a Forge release, but the upgrade should be safe
| @@ -27,7 +27,7 @@ | |||
| "fs-extra": "^10.0.0" | |||
| }, | |||
| "optionalDependencies": { | |||
| "@malept/electron-installer-flatpak": "^0.11.2" | |||
| /** | ||
| * If the `RunAsNode` fuse had not been flipped, | ||
| * this would return the Node.js version (e.g. `v14.16.0`) | ||
| * instead of the `console.log` from `main.js`. | ||
| */ | ||
| const output = ( | ||
| await spawn(electronExecutablePath, ['-v'], { |
There was a problem hiding this comment.
VerteDinde
approved these changes
Jun 5, 2023
| @@ -143,11 +143,11 @@ | |||
| "yaml-hook": "^1.0.0" | |||
| }, | |||
| "optionalDependencies": { | |||
| "@malept/electron-installer-flatpak": "^0.11.2", | |||
There was a problem hiding this comment.
I'm fine with upgrading these in this PR, as long as tests are passing 👍 We can do a little manual test of binaries next time we do a Forge release, but the upgrade should be safe
erickzhao
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates Forge from GitHub Actions to CircleCI
Notes: none