Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: junit reporter adjustments #3324

Merged
merged 2 commits into from
Aug 30, 2023
Merged

ci: junit reporter adjustments #3324

merged 2 commits into from
Aug 30, 2023

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Aug 30, 2023 •
edited
Loading

Follow-up to #3316

Test timings are still busted, so I followed CircleCI's troubleshooting docs here: https://support.circleci.com/hc/en-us/articles/360021624194-Test-Summary-Troubleshooting

Two things that we weren't respecting:

  • XML reports need to go inside a subfolder of the main test summary folder.
  • Paths need to match the output of the test glob from the circleci CLI. This means that we need to convert the output strings from mocha-junit-reporter from absolute paths to relative paths.

@erickzhao erickzhao changed the title testing wip: test Aug 30, 2023
@erickzhao erickzhao changed the title wip: test ci: test Aug 30, 2023
@erickzhao erickzhao marked this pull request as ready for review August 30, 2023 21:28
@erickzhao erickzhao requested a review from a team as a code owner August 30, 2023 21:28
@erickzhao erickzhao changed the title ci: test ci: junit reporter adjustments Aug 30, 2023
@erickzhao erickzhao merged commit 9ab274d into main Aug 30, 2023
6 of 7 checks passed
@erickzhao erickzhao deleted the build/test-parallelization-improvements branch August 30, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsanders11 dsanders11 dsanders11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erickzhao @dsanders11