Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sandbox support #411

Closed
wants to merge 4 commits into from
Closed

Add sandbox support #411

wants to merge 4 commits into from

Conversation

kewde
Copy link

@kewde kewde commented Jan 14, 2018

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
Adds support for --enable-sandbox, to be passed on to electron when executed.

@MarshallOfSound
Copy link
Member

I think we're going to pass on this, you can already achieve this yourself with electron-forge start -- --enable-sandbox. If we add a custom flag for every Electron / Chromium / NodeJS option it will become unmanageable and we have to draw a line somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants