Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url get Bug #153

Closed
wants to merge 1 commit into from
Closed

Conversation

shenlanchenwei
Copy link

There is an error in the address, and a "V" is added, which causes an error.

There is an error in the address, and a "V" is added, which causes an error.
@shenlanchenwei
Copy link
Author

image

@shenlanchenwei shenlanchenwei mentioned this pull request Mar 26, 2020
@vhashimotoo
Copy link

Please see electronjs.org/docs/tutorial/installation#mirror for mirror instructions.

Can you please check these:

ELECTRON_MIRROR="https://cdn.npm.taobao.org/dist/electron/"

or

ELECTRON_MIRROR="https://npm.taobao.org/mirrors/electron/"
ELECTRON_CUSTOM_DIR="{{ version }}"

@shenlanchenwei
Copy link
Author

thanks

@vhashimotoo vhashimotoo added the 🚫 invalid This doesn't seem right label Mar 26, 2020
@aprilandjan
Copy link

ELECTRON_MIRROR="https://cdn.npm.taobao.org/dist/electron/"

Just want to say that the first part

ELECTRON_MIRROR="https://cdn.npm.taobao.org/dist/electron/"

is ok for download, but the second part

ELECTRON_MIRROR="https://npm.taobao.org/mirrors/electron/"
ELECTRON_CUSTOM_DIR="{{ version }}"

is not able for download because the real customDir is infact v{{ version }}. To be honest, the instruction is somehow misleading. Many people(me included) are anxious to find a solution and will not read the instructions carefully at first glance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚫 invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants