Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fallback location and document how to migrate #55

Closed
wants to merge 1 commit into from

Conversation

kevinsawicki
Copy link
Contributor

@kevinsawicki kevinsawicki commented May 10, 2017

Instead of supporting a fallback location to the old cache directory, this pull request removes it and just documents how people can move it over.

It seems worthwhile to just do a clean break here to simplify the code and have consistent behavior in terms of where assets are pull from.

Refs #54
Refs #37

/cc @malept @Siilwyn

Copy link

@zeke zeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kevinsawicki
Copy link
Contributor Author

Thought about this some more, I think it makes sense to go with the fallback location to start since to avoid bumping the major, can revisit in the future though possibly when other major API changes are also in the works.

@Siilwyn
Copy link
Contributor

Siilwyn commented May 10, 2017

Phew, so I didn't waste those hours after all. 😛
I actually don't like fallbacks so much but for much depended on modules it might make sense. Benefit is also that after a while the old cache will only contain old electron versions which are probably used less in the future.

@malept malept deleted the remove-cache-fallback branch May 10, 2017 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants