This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix: include names.h in zlib header package #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
approved these changes
Oct 11, 2018
There was a problem hiding this comment.
FYI, for anyone in the future who might be digging around to find out why this header is needed in electron's headers but not node's (see node's install script which doesn't include names.h), it's because we build against Chromium's zlib, which redefines all zlib names as Cr_z_: https://chromium.googlesource.com/chromium/src/+/69.0.3497.106/third_party/zlib/names.h
nornagon
approved these changes
Oct 11, 2018
|
Thanks @adill! |
nornagon
added a commit
to electron/electron
that referenced
this pull request
Oct 11, 2018
picks up electron/node#74: fix: include names.h in zlib header package
2 tasks
nornagon
added a commit
to electron/electron
that referenced
this pull request
Oct 11, 2018
picks up: - electron/node#73: fix: export libuv symbols - electron/node#74: fix: include names.h in zlib header package
trop-bot
pushed a commit
to trop-bot/electron
that referenced
this pull request
Oct 11, 2018
picks up: - electron/node#73: fix: export libuv symbols - electron/node#74: fix: include names.h in zlib header package
jkleinsc
pushed a commit
to electron/electron
that referenced
this pull request
Oct 12, 2018
picks up: - electron/node#73: fix: export libuv symbols - electron/node#74: fix: include names.h in zlib header package
trop-bot
pushed a commit
to trop-bot/electron
that referenced
this pull request
Oct 12, 2018
picks up: - electron/node#73: fix: export libuv symbols - electron/node#74: fix: include names.h in zlib header package
codebytere
pushed a commit
to electron/electron
that referenced
this pull request
Oct 12, 2018
picks up: - electron/node#73: fix: export libuv symbols - electron/node#74: fix: include names.h in zlib header package
MarshallOfSound
pushed a commit
that referenced
this pull request
Oct 25, 2018
MarshallOfSound
pushed a commit
that referenced
this pull request
Oct 25, 2018
deepak1556
pushed a commit
that referenced
this pull request
Dec 10, 2018
deepak1556
pushed a commit
that referenced
this pull request
Dec 11, 2018
deepak1556
pushed a commit
that referenced
this pull request
Dec 19, 2018
deepak1556
pushed a commit
that referenced
this pull request
Dec 19, 2018
deepak1556
pushed a commit
that referenced
this pull request
Dec 19, 2018
deepak1556
pushed a commit
that referenced
this pull request
Dec 25, 2018
nitsakh
pushed a commit
that referenced
this pull request
Mar 18, 2019
nitsakh
pushed a commit
that referenced
this pull request
Mar 18, 2019
nitsakh
pushed a commit
that referenced
this pull request
Mar 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.