Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix: backport a node commit that cleans up GC listeners (5-0-x) #94

Merged
merged 1 commit into from Mar 5, 2019
Merged

fix: backport a node commit that cleans up GC listeners (5-0-x) #94

merged 1 commit into from Mar 5, 2019

Conversation

brenca
Copy link

@brenca brenca commented Mar 5, 2019

Backports acc5a86.

@addaleax @brenca
perf_hooks: clean up GC listeners
d2bb4b9 
Add Environment cleanup hooks to remove GC listeners when the
`Environment` is torn down.

PR-URL: nodejs/node#25647
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@brenca brenca mentioned this pull request Mar 5, 2019
Merged
6 tasks
nornagon
nornagon suggested changes Mar 5, 2019
View reviewed changes
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please edit the PR title to reflect what actually got backported

@brenca brenca changed the title fix: backport one node commit (5-0-x) fix: backport a node commit that cleans up GC listeners (5-0-x) Mar 5, 2019
@brenca
Copy link
Author

brenca commented Mar 5, 2019

@nornagon updated the title!

@codebytere codebytere merged commit f807d72 into electron-node-canary Mar 5, 2019
@codebytere codebytere deleted the brenca/bp-gc-listener-cleanup branch March 5, 2019 17:17
@brenca brenca mentioned this pull request Mar 15, 2019
Merged
6 tasks
nitsakh pushed a commit that referenced this pull request Mar 18, 2019
@brenca @nitsakh
perf_hooks: clean up GC listeners (#94)
ceebcb8 
Add Environment cleanup hooks to remove GC listeners when the
`Environment` is torn down.

PR-URL: nodejs/node#25647
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nitsakh pushed a commit that referenced this pull request Mar 18, 2019
@brenca @nitsakh
perf_hooks: clean up GC listeners (#94)
bd34d5c 
Add Environment cleanup hooks to remove GC listeners when the
`Environment` is torn down.

PR-URL: nodejs/node#25647
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nitsakh pushed a commit that referenced this pull request Mar 18, 2019
@brenca @nitsakh
perf_hooks: clean up GC listeners (#94)
e05e320 
Add Environment cleanup hooks to remove GC listeners when the
`Environment` is torn down.

PR-URL: nodejs/node#25647
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nornagon nornagon nornagon approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@brenca @nornagon @deepak1556 @codebytere @MarshallOfSound @addaleax