Automating entitlement app group only if there is entitlements

[develar]

Otherwise if platform darwin no entitlements by default and sign failed because preAutoEntitlementAppGroupAsync does readFileAsync(opts.entitlements, 'utf8')

[sethlu]

@develar I think we still need to pass down something like return Promise.resolve() otherwise the promise chain breaks.

[develar]

No,

If the value is a thenable (i.e. has a then method), the returned promise will "follow" that thenable, adopting its eventual state; otherwise the returned promise will be fulfilled with the value.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise

If you want to state that return is not missed, return null: return null. FYI: e.g. typescript doesn't require explicit return in the async function even if there are other return in the function. Just because it is very convenient.

[sethlu]

@develar I don't know but a similar case has caused a slight issue previously... not sure if being a same cause: 184985a. Would you mind having a check?

Probably that's a different case because of returning a promise obj so what following uses it before continuing .then()?

[develar]

Yes, it was an error in my PR (https://github.com/electron-userland/electron-osx-sign/pull/45/files#diff-168726dbe96b3ce427e7fedce31bb0bcR192) It is promise pitfall, when you forget to return promise result in the then hander :(

[sethlu]

@develar No worries, thanks for clarifying 😸 I didn't notice it earlier as well.

[sethlu]

@develar Thanks for bringing up these issue fixes and the updates on the typescript; 👍 really appreciated them! Do you mind having a look at some of the comments on file changes?

[sethlu]

@develar PR merged; thanks for working on these improvements. 👍