Fix infer electron test introduced in 7.5.0

[malept]

Since #435 was merged, tests for Node 4 in all host platforms intermittently raise an exception at the new infer Electron test.

Examples:

• Windows
• OS X
• Linux

CC: @zeke

[zeke]

ack. investigating.

[malept]

I took a couple of minutes to look into it this morning. Here's how I reliably reproduced the problem:

1. Switch to Node 4 environment (I used nodeenv)
2. Take an existing checkout of electron-packager (<= 7.4.0) and run git pull && npm install
3. Run node test/basic.js, not npm test

This intermittent error may have actually been an indicator for the problem in #439, but I'll need to see what CI says about that. In the meantime, I committed bcc7cac which at least gives a better exception.

[malept]

😞 still happening: https://travis-ci.org/electron-userland/electron-packager/jobs/150300592#L273

I'm dropping it from the 7.5.1 milestone but I'd still like this to get fixed ASAP.

[zeke]

Following these steps:

n 4.4.7
git checkout tags/v7.4.0
rm -rf node_modules
npm i
node test/basic.js

I have run the tests several times and am not able to produce an error.

[malept]

If I've learned anything from debugging intermittent test failures in general, it's that running a test in a testsuite vs. a single file has a tendency to be different, if a) your test runner does not isolate your tests properly, or b) you don't write your setup/teardown functions to isolate your tests properly.

My suspicion is that the failure will happen more often when running npm test rather than node test/basic.js.

[malept]

I don't consider this fixed (because it still happens intermittently), so I'm reopening.

[malept]

Regarding the reproduction steps in #441 (comment) - they reliably reproduced the error until after bcc7cac was committed. Now it's just an intermittent error.

To assist in debugging this issue, I removed the use of tap-spec, which I suspect is hiding the real reason why it's failing.

[malept]

Well, that's significantly more helpful:

https://travis-ci.org/electron-userland/electron-packager/jobs/151815017#L252-L283

[kevinsawicki]

Can this be closed now? It doesn't seem to be happening once #452 was merged with the npm install --no-bin-links change.

[malept]

Sounds good.

[zeke]

Thanks for the help getting this fixed.