Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send the properly formatted options from the CLI to electron-osx-sign #1047

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

jhen0409
Copy link
Contributor

@jhen0409 jhen0409 commented Aug 31, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fix osx-sign can't get correctly sub properties, just use osx-sign arg instead of osxSign.

For yargs-parser, use camel case of args is meaning the subprops will be also converted to camel case, but it will break the osx-sign usage like entitlements-inherit.

@jhen0409 jhen0409 changed the title Fix osx-sign can't get correctly sub properties for CLI fix: osx-sign can't get correctly sub properties for CLI Aug 31, 2019
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. The fix is in the wrong place, as this affects the CLI only, and there needs to be a regression test added (to test/cli.js). If you can get these things done, we can merge this.

src/mac.js Outdated Show resolved Hide resolved
@malept malept added bug 🐛 build-target:mac 🍎 Bundling an Electron app specifically for macOS labels Aug 31, 2019
@malept malept changed the title fix: osx-sign can't get correctly sub properties for CLI fix: send the properly formatted options from the CLI to electron-osx-sign Aug 31, 2019
@codecov-io
Copy link

codecov-io commented Aug 31, 2019

Codecov Report

Merging #1047 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1047   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         689     691    +2     
======================================
+ Hits          689     691    +2
Impacted Files Coverage Δ
src/cli.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ed0a4b...5d84a38. Read the comment docs.

@malept malept merged commit 1bb9edd into electron:master Sep 9, 2019
@jhen0409 jhen0409 deleted the fix-osx-sign-subprops branch September 13, 2019 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 build-target:mac 🍎 Bundling an Electron app specifically for macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants