unzip should preserve symbolic links on windows #1082
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Here are some highlighted action items that will help get it across the finish line, from the
Development and triage is community-driven, so please be patient and we will get back to you as soon as we can. |
reverts #984
Codecov Report
@@ Coverage Diff @@
## master #1082 +/- ##
==========================================
- Coverage 97.57% 97.55% -0.03%
==========================================
Files 14 14
Lines 702 695 -7
==========================================
- Hits 685 678 -7
Misses 17 17
Continue to review full report at Codecov.
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding test which shows that
cross-zipdoes not preserve symbolic links on windows. After this build fails I will add another commit which reverts #984 to show that this worked before.Fixing this is only the first step in enabling building macOS packages on windows.
The next problem is that
fs-extrais usingfs.statinstead offs.lstatwhich failes for symbolic links on windows. (I will open an issue there and see if this is intended or not.) So the package can not be moved:https://github.com/electron/electron-packager/blob/2e974d1211020eb22ac75c21cc0966b9bfaac216/src/platform.js#L215
EDIT: Or maybe this is only an issue on my machines? Because all the
fs-extrasymlink tests are failing on my machine even when running as administrator... I will investigate more...