Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create tmp directory without using app name #1585

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

felixrieseberg
Copy link
Member

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes: Fix: Don't use app name when creating temporary directories, ensuring that npm scripts expecting paths without spaces will work fine.

@felixrieseberg felixrieseberg requested a review from a team as a code owner October 25, 2023 18:55
@welcome
Copy link

welcome bot commented Oct 25, 2023

Thanks for opening a pull request!

Here are some highlighted action items that will help get it across the finish line, from the
pull request guidelines:

  • Follow the JavaScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes in NEWS.md and other docs.
  • Include tests when adding/changing behavior.

Development and triage is community-driven, so please be patient and we will get back to you as soon as we can.

@felixrieseberg felixrieseberg changed the title Create tmp directory without using app name fix: Create tmp directory without using app name Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #1585 (bcea152) into main (418011a) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1585      +/-   ##
==========================================
- Coverage   95.58%   95.46%   -0.13%     
==========================================
  Files          15       15              
  Lines         793      793              
==========================================
- Hits          758      757       -1     
- Misses         35       36       +1     
Files Coverage Δ
src/platform.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@felixrieseberg felixrieseberg merged commit 75146a7 into main Oct 25, 2023
4 of 6 checks passed
@felixrieseberg felixrieseberg deleted the felixr-space-build branch October 25, 2023 19:02
@welcome
Copy link

welcome bot commented Oct 25, 2023

Thanks for your contribution! 🎉

Copy link

🎉 This PR is included in version 18.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants