-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump electronjs/node to 2.1.0 (main) #1605
Conversation
Thanks for opening a pull request! Here are some highlighted action items that will help get it across the finish line, from the
Development and triage is community-driven, so please be patient and we will get back to you as soon as we can. |
5631069
to
78707f3
Compare
a2a8dab
to
99f5e93
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1605 +/- ##
=======================================
Coverage 91.80% 91.80%
=======================================
Files 16 16
Lines 854 854
Branches 167 167
=======================================
Hits 784 784
Misses 52 52
Partials 18 18 ☔ View full report in Codecov by Sentry. |
b794dcb
to
d864448
Compare
d864448
to
1eea180
Compare
Required tweaking the Electron versions in the test because the default version being used for all tests was 1.4.13, which doesn't support Apple Silicon. Bumping the default revealed that some tests are testing older Electron behavior, so the versions had to be tweaked accordingly until everyone was happy. |
🎉 This PR is included in version 18.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Updating electronjs/node to 2.1.0 (main)