Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump electronjs/node to 2.1.0 (main) #1605

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

electron-roller[bot]
Copy link
Contributor

@electron-roller electron-roller bot commented Nov 16, 2023

Updating electronjs/node to 2.1.0 (main)

@electron-roller electron-roller bot requested a review from a team as a code owner November 16, 2023 21:18
Copy link

welcome bot commented Nov 16, 2023

Thanks for opening a pull request!

Here are some highlighted action items that will help get it across the finish line, from the
pull request guidelines:

  • Follow the JavaScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes in NEWS.md and other docs.
  • Include tests when adding/changing behavior.

Development and triage is community-driven, so please be patient and we will get back to you as soon as we can.

@georgexu99 georgexu99 force-pushed the roller/orb/electronjs/node/main branch from 5631069 to 78707f3 Compare November 22, 2023 02:01
@georgexu99 georgexu99 changed the title chore: bump electronjs/node to 2.1.0 (main)) chore: bump electronjs/node to 2.1.0 (main) Nov 22, 2023
@georgexu99 georgexu99 force-pushed the roller/orb/electronjs/node/main branch from a2a8dab to 99f5e93 Compare November 28, 2023 21:28
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b199e6) 91.80% compared to head (1eea180) 91.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1605   +/-   ##
=======================================
  Coverage   91.80%   91.80%           
=======================================
  Files          16       16           
  Lines         854      854           
  Branches      167      167           
=======================================
  Hits          784      784           
  Misses         52       52           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsanders11 dsanders11 force-pushed the roller/orb/electronjs/node/main branch 3 times, most recently from b794dcb to d864448 Compare December 13, 2023 18:27
@dsanders11 dsanders11 force-pushed the roller/orb/electronjs/node/main branch from d864448 to 1eea180 Compare December 13, 2023 18:36
@dsanders11
Copy link
Member

Required tweaking the Electron versions in the test because the default version being used for all tests was 1.4.13, which doesn't support Apple Silicon. Bumping the default revealed that some tests are testing older Electron behavior, so the versions had to be tweaked accordingly until everyone was happy.

@dsanders11 dsanders11 merged commit 03347ec into main Dec 13, 2023
5 checks passed
@dsanders11 dsanders11 deleted the roller/orb/electronjs/node/main branch December 13, 2023 20:19
Copy link

🎉 This PR is included in version 18.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant