-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add @electron/windows-sign #1609
Conversation
async create () { | ||
await this.initialize() | ||
await this.renameElectron() | ||
await this.copyExtraResources() | ||
await this.runRcedit() | ||
await this.signAppIfSpecified() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this definitely run after the afterCopy
hook? Just double checking this is run after any potential mutations to the exe. E.g. via fuses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! The only thing that happens after is moving the package to its final destination and the afterComplete
hook. For future convenience, this is also exactly when we sign & notarize on macOS.
Co-authored-by: Samuel Attard <sam@electronjs.org>
🎉 This PR is included in version 18.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@felixrieseberg how exactly I should use it? I tried object with just UPD:
|
Summarize your changes:
This PR adds @electron/windows-sign, enabling this module to codesign Windows binary files. Both logic and configuration are analogous to @electron/osx-sign -- on purpose, to keep the API simple and easy to use.