-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Unable to set icon' #56
Comments
Thanks for finding out the troubling commit, I must have broken something when refactoring, I'll look into it. |
still got same error: |
I don't think node-rcedit has been updated with this fix. There's a slight problem if you do that, anyway (see #66). |
rcedit.exe failed with exit code 1. Reserved header is not 0 or image type is not icon for 'p' |
Using the current rcedit artifact leads to the above mentioned error: 'Unable to set icon'.
The error was introduced in commit af37f5f.
(I verified this with artifacts from https://ci.appveyor.com/project/electron-bot/rcedit/build/1.0.23/job/bc57s50clgkbab7x/artifacts and https://ci.appveyor.com/project/electron-bot/rcedit/build/1.0.22/job/brndccen9f9ovdc2/artifacts. The artifact from the previous commit - d65120c - worked.)
The changes to the function
SetIcon
may have caused this.Here is the test output from https://github.com/electron/node-rcedit with the artifact from https://ci.appveyor.com/project/electron-bot/rcedit/build/1.0.23/job/bc57s50clgkbab7x/artifacts:
This output is from running the node-rcedit tests with a current artifact:
The text was updated successfully, but these errors were encountered: