Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add default reviewers to manual backports #274

Merged
merged 6 commits into from
Apr 2, 2024
Merged

fix: add default reviewers to manual backports #274

merged 6 commits into from
Apr 2, 2024

Conversation

alicelovescake
Copy link
Member

This PR:

  • Adds reviewers to manual backports
  • Adds tests to updateManualBackport

@alicelovescake alicelovescake requested a review from a team as a code owner April 1, 2024 05:43
dsanders11
dsanders11 reviewed Apr 1, 2024
View reviewed changes
spec/operations.spec.ts Outdated Show resolved Hide resolved
spec/operations.spec.ts Show resolved Hide resolved
src/operations/update-manual-backport.ts Outdated Show resolved Hide resolved
src/operations/update-manual-backport.ts Outdated Show resolved Hide resolved
spec/operations.spec.ts Outdated Show resolved Hide resolved
dsanders11
dsanders11 reviewed Apr 1, 2024
View reviewed changes
spec/operations.spec.ts Outdated Show resolved Hide resolved
dsanders11
dsanders11 approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@alicelovescake
Copy link
Member Author

alicelovescake commented Apr 1, 2024 •
edited
Loading

LGTM, thanks! 👍

Thanks for the great feedback and following up with the release WG! Let me know if you can help me merge it when you get a chance!

@georgexu99 georgexu99 merged commit 4744d0b into electron:main Apr 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgexu99 georgexu99 georgexu99 approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alicelovescake @dsanders11 @georgexu99