-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add try catch to reviewer #279
refactor: add try catch to reviewer #279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes to tests should mostly be backed out and put in a new spec/utils.spec.ts
which tests tagBackportReviewers
directly. The changes to spec/operations.spec.ts
get too into the implementation details of tagBackportReviewers
, it was better when it was checking just if tagBackportReviewers
was called, and we can put testing of error handling inside tagBackportReviewers
in the spec/utils.spec.ts
file.
Ah yes, agreed that for the updateManualBackport function, it was testing the implementation details of tagBackportReviewers more. Made a new test file with similar changes + a test checking that users is added to reviewers correctly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alicelovescake!
This PR: