Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: event emitter on extended Process #264

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

mxschmitt
Copy link
Contributor

Fixes electron/electron#40942

See electron/electron#40942 (comment) for investigation notes.

src/module-declaration.ts Outdated Show resolved Hide resolved
src/module-declaration.ts Outdated Show resolved Hide resolved
@mxschmitt
Copy link
Contributor Author

@MarshallOfSound would it be possible that this makes it into Electron v27?

@codebytere codebytere merged commit 0fc0420 into electron:main Apr 17, 2024
3 checks passed
Copy link

🎉 This PR is included in version 8.15.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dsanders11
Copy link
Member

@mxschmitt, unfortunately this missed the cutoff for the final v27 release before it became unsupported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: EventEmitter types in electron.d.ts colliding with Node JS types.
4 participants