Exporting MakeUniversalOpts #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to allow other packages to extract specific logic/options with typesafety
MarshallOfSound
approved these changes
Oct 3, 2022
|
🎉 This PR is included in version 1.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow other packages to extract specific logic/options with typesafety
Context: Electron-Builder integrates with electron/universal and, right now, has to add a new config property whenever electron/universal changes/adds to
MakeUniversalOpts. What I'd like to do is to be able to add auniversal: MakeUniversalOptsobject to our Mac Options such that it simply stays up to date whenever our electron/universal dep is updatedRef: electron-userland/electron-builder#6913 (comment)