[patch] update observavir

electrovir · Apr 4, 2024 · de804f9 · de804f9
1 parent d2880fc
commit de804f9
Show file tree

Hide file tree

Showing 11 changed files with 71 additions and 33 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@electrovir/element-vir-mono-repo",
-    "version": "22.0.3",
+    "version": "22.0.4",
     "private": true,
     "license": "(MIT or CC0 1.0)",
     "author": {

diff --git a/packages/element-book-example/package.json b/packages/element-book-example/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@electrovir/element-book-example",
-    "version": "22.0.3",
+    "version": "22.0.4",
     "private": true,
     "license": "(MIT or CC0 1.0)",
     "scripts": {

diff --git a/packages/element-book/package.json b/packages/element-book/package.json
@@ -1,6 +1,6 @@
 {
     "name": "element-book",
-    "version": "22.0.3",
+    "version": "22.0.4",
     "keywords": [
         "book",
         "design system",
@@ -48,7 +48,7 @@
         "lit-css-vars": "^3.0.9",
         "spa-router-vir": "^3.0.4",
         "typed-event-target": "^3.2.1",
-        "vira": "22.0.3"
+        "vira": "22.0.4"
     },
     "devDependencies": {
         "@augment-vir/browser-testing": "^26.2.1",

diff --git a/packages/element-vir-example/package.json b/packages/element-vir-example/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@electrovir/element-vir-example",
-    "version": "22.0.3",
+    "version": "22.0.4",
     "private": true,
     "license": "(MIT or CC0 1.0)",
     "author": {

diff --git a/packages/element-vir/package.json b/packages/element-vir/package.json
@@ -1,6 +1,6 @@
 {
     "name": "element-vir",
-    "version": "22.0.3",
+    "version": "22.0.4",
     "keywords": [
         "custom",
         "web",
@@ -44,7 +44,7 @@
         "lit-css-vars": "^3.0.9",
         "lit-html": "^3.1.2",
         "object-shape-tester": "^2.3.2",
-        "observavir": "^1.1.1",
+        "observavir": "^1.1.2",
         "run-time-assertions": "^1.2.0",
         "typed-event-target": "^3.2.1"
     },

diff --git a/packages/element-vir/src/declarative-element/directives/async-prop.test.ts b/packages/element-vir/src/declarative-element/directives/async-prop.test.ts
@@ -8,7 +8,7 @@ import {
     waitUntilTruthy,
 } from '@augment-vir/common';
 import {assert, fixture as renderFixture, waitUntil} from '@open-wc/testing';
-import {isObservableBase} from 'observavir';
+import {isObservableBase, noUpdate} from 'observavir';
 import {assertDefined, assertInstanceOf, assertThrows, assertTypeOf} from 'run-time-assertions';
 import {nothing} from '../../lit-exports/all-lit-exports';
 import {html} from '../../template-transforms/vir-html/vir-html';
@@ -656,4 +656,42 @@ describe(asyncProp.name, () => {
         await wait(updateDuration.milliseconds * 2);
         assert.strictEqual(rendered.instanceState.myProp.value, 42);
     });
+
+    it('allows noUpdate', async () => {
+        const VirAsyncPropWithNoUpdate = defineElementNoInputs({
+            tagName: 'vir-async-prop-with-update',
+            stateInitStatic: {
+                asyncValues: asyncProp({
+                    async updateCallback({
+                        shouldBypass,
+                        value,
+                    }: {
+                        value: string;
+                        shouldBypass: boolean;
+                    }): Promise<ReadonlyArray<string> | typeof noUpdate> {
+                        if (shouldBypass) {
+                            return noUpdate;
+                        }
+
+                        return Array(10)
+                            .fill(0)
+                            .map(() => value);
+                    },
+                }),
+            },
+            renderCallback: ({state}) => {
+                console.log(state.asyncValues.value);
+                state.asyncValues.update({value: 'hello there', shouldBypass: true});
+                return 'hi';
+            },
+        });
+
+        const rendered = await renderFixture(html`
+            <${VirAsyncPropWithNoUpdate}></${VirAsyncPropWithNoUpdate}>
+        `);
+
+        assertInstanceOf(rendered, VirAsyncPropWithNoUpdate);
+        await waitUntilTruthy(() => rendered._internalRenderCount > 0);
+        assert.instanceOf(rendered.instanceState.asyncValues.value, Promise);
+    });
 });
diff --git a/packages/scripts/package.json b/packages/scripts/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@electrovir/scripts",
-    "version": "22.0.3",
+    "version": "22.0.4",
     "private": true,
     "license": "(MIT or CC0 1.0)",
     "author": {

diff --git a/packages/theme-vir/package.json b/packages/theme-vir/package.json
@@ -1,6 +1,6 @@
 {
     "name": "theme-vir",
-    "version": "22.0.3",
+    "version": "22.0.4",
     "private": true,
     "description": "Create an entire web theme.",
     "keywords": [

diff --git a/packages/vira-book/package.json b/packages/vira-book/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@electrovir/vira-book",
-    "version": "22.0.3",
+    "version": "22.0.4",
     "private": true,
     "license": "(MIT or CC0 1.0)",
     "author": {

diff --git a/packages/vira/package.json b/packages/vira/package.json
@@ -1,6 +1,6 @@
 {
     "name": "vira",
-    "version": "22.0.3",
+    "version": "22.0.4",
     "description": "A simple and highly versatile design system using element-vir.",
     "keywords": [
         "design",