Macro improvement #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarogh
force-pushed
the
macro-improvements
branch
from
c3a0066
to
c85a140
Compare
Misses support for types, will come with next rebase.
edgarogh
force-pushed
the
macro-improvements
branch
from
c85a140
to
fb7d2bc
Compare
|
There are a few tests and they seem to pass. Not sure if everything is sound though. |
edgarogh
force-pushed
the
macro-improvements
branch
from
fb7d2bc
to
fff0641
Compare
elegaanz
reviewed
Mar 21, 2023
| /// | ||
| /// It erases all lifetime data, beware of that. | ||
| #[derive(Clone, Copy, Debug, Hash, Eq, PartialEq, PartialOrd, Ord)] | ||
| pub struct NsTypeId(usize); |
There was a problem hiding this comment.
j'ai l'impression de faire de l'objective c avec ce nom de type 🤮
elegaanz
approved these changes
Mar 21, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix everything in #5