Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fixing exodus CI job #8721

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Try fixing exodus CI job #8721

merged 2 commits into from
Jan 2, 2024

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Dec 26, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Make Exodus ignore Sentry, as it's a known an opt-in tracker.

Motivation and context

Exodus now detects Sentry and was failing because of this. The new code should ensure it's the only detected tracker and make the check pass.

@jmartinesp jmartinesp force-pushed the test/jme/exodus branch 6 times, most recently from ad6fa3e to f9f26fb Compare December 26, 2023 12:15
@jmartinesp jmartinesp marked this pull request as ready for review December 26, 2023 12:40
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hence I did not spend time to test the changes.

@jmartinesp jmartinesp merged commit c46b314 into develop Jan 2, 2024
13 of 14 checks passed
@jmartinesp jmartinesp deleted the test/jme/exodus branch January 2, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants