Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
This change ensure that the user Avatar used in location Event rendering is the same avatar than the avatar of the user in the room. Previously the application was using the Avatar from the user profile, but it can happen that the profile is not loaded into the DB, and so the fallback avatar was used (with the userId first later). As a consequence, if the user has set a avatar just on the current room, it will also be used.
This PR also improves how the cache works in
LocationPinProvider
. Rely on Glide cache, limit size, and invalidate cache in case of error, then success retrieving avatar data. Also useUserItem
for the cache key, to invalidate cache if user avatar / display name change. So this PR also fix a refresh issue if user change their avatar.This PR also fix a rendering issue of the initial avatar when long clicking on a location Event.
Motivation and context
User user avatar in Location share Event.
Parity with Element Web.
Screenshots / GIFs
Tests
Tested devices
Checklist