Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rooms directory: the room preview is broken #2126

Closed
giomfo opened this issue Dec 13, 2018 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#615
Closed

Rooms directory: the room preview is broken #2126

giomfo opened this issue Dec 13, 2018 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#615
Labels
A-Lazy-Loading P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Milestone
Sprint 16

Comments

@giomfo
Copy link
Member

giomfo commented Dec 13, 2018

Riot-ios fails to display the room preview on a world-readable public room.
An infinite loading wheel is displayed.

This is a regression introduced by https://github.com/matrix-org/matrix-ios-sdk/blob/975443b725670e0ff8713141ec67e141ca4be503/MatrixSDK/Data/MXEventTimeline.m#L334

(see matrix-org/matrix-ios-sdk@2ee14c6#diff-027418dcbfead28c14c64267bcb81baa)
@giomfo giomfo added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems P1 labels Dec 13, 2018
@giomfo giomfo mentioned this issue Dec 13, 2018
Closed
@manuroe manuroe added this to the Sprint 16 milestone Dec 13, 2018
@manuroe manuroe added the LL label Dec 18, 2018
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jan 3, 2019
@manuroe
BF: MXPeekingRoom: the room preview is broken
90ca7b2 
element-hq/element-ios/issues/2126
@manuroe manuroe mentioned this issue Jan 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Lazy-Loading P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
Sprint 16
Development

Successfully merging a pull request may close this issue.

BF: MXPeekingRoom: the room preview is broken matrix-org/matrix-ios-sdk
3 participants
@kittykat @manuroe @giomfo