Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room upgrade: Use the server_name parameter when joining the new room #2550

Closed
manuroe opened this issue Jul 4, 2019 · 1 comment · Fixed by #2557
Closed

Room upgrade: Use the server_name parameter when joining the new room #2550

manuroe opened this issue Jul 4, 2019 · 1 comment · Fixed by #2557
Assignees
@manuroe
Labels
A-Room-Upgrades feature P1 parity-with-web T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Milestone
Sprint 20

Comments

@manuroe
Copy link
Member

manuroe commented Jul 4, 2019 •
edited
Loading

The client just needs to send a server_name alongside the join call to the new room. Convention is to use the tombstone event sender's server name.

This is applicable only on public rooms.

Web PR: matrix-org/matrix-react-sdk#3159

Discussion: https://matrix.to/#/!zVpPeWAObqutioiNzB:jki.re/$cKuuTGJdMD9lVWAUDRl9Tln1Ol1APbwJO1G6C2HtO6U?via=matrix.org&via=librepush.net&via=sw1v.org
This was referenced Jul 4, 2019
Closed
Closed
@manuroe manuroe added this to the Sprint 20 milestone Jul 4, 2019
@manuroe manuroe self-assigned this Jul 4, 2019
@manuroe
Copy link
Member Author

manuroe commented Jul 5, 2019 •
edited
Loading

This issue requires some bits of #2547.

manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jul 8, 2019
@manuroe
MXTools: add serverNameInMatrixIdentifier
3efb07a 
Part of element-hq/element-ios#2550.

Useful to build via parameters for permalinks
manuroe added a commit that referenced this issue Jul 8, 2019
@manuroe
Room upgrade: Use the server_name parameter when joining the new room
0d5eac4 
#2550
This was referenced Jul 8, 2019
Merged
Merged
Merged
@kittykat kittykat added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuroe manuroe

Labels
A-Room-Upgrades feature P1 parity-with-web T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
Sprint 20
Development

Successfully merging a pull request may close this issue.

Join Room: Support via parameters to better handle federation element-hq/element-ios
2 participants
@kittykat @manuroe